TraceId timestamp supports string starts with '0' #641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
If upstream is sending X-Ray like trace id but with timestamp section starts with
0
, such as "1-0074e2eb-694001932729d04067bb5440"Actual,
The bug is: the trace id is parsed to "1-74e2eb-694001932729d04067bb5440".
Expected
The expected behavior is: the trace id is parsed to "1-0074e2eb-694001932729d04067bb5440".
Description of changes:
If the timestamp section in X-Ray like trace id less than 8 digits, pad
0
s as prefix.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes:
Unit Test