Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated actions/checkout, actions/setup-node, and codecov package versions to fix CI #574

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

carolabadeer
Copy link
Contributor

@carolabadeer carolabadeer commented Mar 3, 2023

Issue #, if available: N/A

Description of changes:
PR build for Node 18.x started failing due to the latest version of npm not being used in the "Setup Node 18.x" step.

npm ERR! enoent ENOENT: no such file or directory, open '/home/runner/work/aws-xray-sdk-node/aws-xray-sdk-node/node_modules/core/package.json'
npm ERR! enoent This is related to npm not being able to find a file.

Updating actions/checkout and actions/setup-node to v3 and adding the check-latest: true flag to ensure the latest npm version is being used resolved this error.

Codecov package used in "Report Coverage" step was also reporting a TypeError that was fixed in v3.8.3, see related issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@carolabadeer carolabadeer requested a review from a team as a code owner March 3, 2023 21:41
@carolabadeer carolabadeer changed the title Updated actions/checkout, actions/setup-node, and codecov packages versions to fix CI Updated actions/checkout, actions/setup-node, and codecov package versions to fix CI Mar 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #574 (ccaab4f) into master (a476e2b) will not change coverage.
The diff coverage is n/a.

❗ Current head ccaab4f differs from pull request most recent head cb4e545. Consider uploading reports for the commit cb4e545 to get more accurate results

@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          37       37           
  Lines        1794     1794           
=======================================
  Hits         1496     1496           
  Misses        298      298           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@carolabadeer carolabadeer merged commit 0fe39de into aws:master Mar 3, 2023
@carolabadeer carolabadeer deleted the fix-node-18-workflows branch March 3, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants