Add test for respecting manually set aws sdk headers #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failing because of deprecated commands, will rerun after fix. |
|
Discussing with AWS SDK team whether this PR reflects desired behavior - will need to wait on merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a unit test to verify that we respect if a customer manually sets their Trace Header for an AWS SDK request, and don't overwrite it with our own header. This is for cases like SFN which are long-running and may require the customer to pass in custom headers which correspond to a particular in-flight execution.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.