Fixing AWS SDK handler for registering all clients using custom AWS Service manifest file #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 29, 2019 16:15
Syncing master
Syncing with base
Sync from master
…ervice manifest file
chrisradek
reviewed
Apr 23, 2019
| { | ||
| _logger.DebugFormat("The provided stream is null, initializing with default AWS whitelist."); | ||
| InitWithDefaultAWSWhitelist(_recorder); | ||
| throw new ArgumentNullException("recorder"); |
There was a problem hiding this comment.
It looks like if the recorder is missing when the XRayPipelineHandler is instantiated we'll throw an exception that isn't caught. Is this the same behavior as before the custom manifest was supported, or should it be logged instead?
There was a problem hiding this comment.
This is a new constructor and inline with existing constructor which maintains the same behavior.
chrisradek
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #74 *
Description of changes:
PR #61 changed the way
XRayPipelineHandlerinstance created, which caused regression. This PR maintains the original behavior as required by the interface.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.