Issue #61: Add option to register XRay manifest from embedded resource #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogiraj07
reviewed
Mar 22, 2019
yogiraj07
suggested changes
Mar 22, 2019
…lt in loading default Manifest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #61 : Add option to register XRay manifest from embedded resource
Description of changes:
Added alternate
RegisterXRayManifest()method which takes aStreaminstead of a file path. To prevent having to leave theStreamopen, modifiedXRayPipelineCustomizerto carry theXRayPipelineHandlerrather thanPathattribute so the manifest can be initialized on the call theRegisterXRayManifest()rather than the call toCustomize().By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.