Fixing bug in RequestUtil.ProcessRequest

[djluck]

Issue: #57

Description of changes:
Don't access the trace context in RequestUtil.ProcessRequest when tracing is disabled. See for more information.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[yogiraj07]

Hi @djluck ,
Can we add unit test with tracing disabled on the recorder for sync and async call for HttpClient and HttpWebRequest.

[djluck]

@yogiraj07 done. I also fixed an issue that would see test HTTP requests time out (response objects were not being disposed, so service point connections were not freed).

[yogiraj07]

Hi @djluck ,
Thank you for the PR.

[djluck]

@yogiraj07 thanks for merging. When can I expect the latest release to be pushed out to nuget?

[yogiraj07]

@djluck , is the fix blocking you? We usually maintain small release cycle.

[djluck]

It is unfortunately (local dev does not work with tracing enabled OR disabled). There seems to be no workaround that I can think of.

[yogiraj07]

@djluck ,

Can you please let me know your usecase ? What problem you are facing for local development? Will this PR fix the issue or not?

[djluck]

I am working on an ASP.NET core application. It has two distinct environments: localdev (i.e. my local machine which does not have an X-Ray trace collection daemon) and lambda (has X-Ray). When running the integration tests locally, all traced HTTP calls fail with the exception outlined in the issue I filed. The reason for this is that some of the instrumented calls happen during test verification- outside the scope of a trace segment.
My solution will be to disable x-ray tracing locally and then enable it when running the application in AWS Lambda, so yes- this PR will fix my issue.

[djluck]

I have been able to work around the issue for now. Thanks for your help @yogiraj07, I can wait for your normal release cycle.