-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cwl): Emit telemetry when starting and stopping liveTail sessions #6047
Conversation
|
@@ -1230,6 +1245,42 @@ | |||
} | |||
], | |||
"passive": true | |||
}, | |||
{ | |||
"name": "cwlLiveTail_Start", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm still not sure why we can't just upstream these to commons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just following the documentation here: https://github.com/aws/aws-toolkit-vscode/blob/master/docs/telemetry.md. I did this in VSCode so my local builds would generate the telemetry objects and I could bundle adding the metrics as well as using them in the same PR. If I need to update commons instead I can send a change for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened PR to upstream to Commons. aws/aws-toolkit-common#916
@@ -350,6 +350,21 @@ | |||
"name": "amazonqMessageDisplayedMs", | |||
"type": "int", | |||
"description": "Duration between the partner teams code receiving the message and when the message was finally displayed in ms" | |||
}, | |||
{ | |||
"name": "livetailSessionAlreadyStarted", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of prefixing these with the product name like we have in the past, you can probably drop the product name as the prefix so that we can make these more general
Problem
Cloudwatch wants to monitor usage metrics of the LiveTail integration
Solution
When starting a session emit telemetry for:
When closing a session:
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.