Fix the CloudWatch Logs table breaking when the service returns an ex… #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ception during loading more (#1951)
abrooksv
reviewed
Aug 25, 2020
| @@ -46,7 +46,7 @@ sealed class LogActor<T>( | |||
| LOG.error(e) { "Exception thrown in the LogStreamActor not handled:" } | |||
| notifyError(title = message("general.unknown_error"), project = project) | |||
| table.setPaintBusy(false) | |||
| Disposer.dispose(this) | |||
There was a problem hiding this comment.
Is this class registered to a parent Disposable?
There was a problem hiding this comment.
Yes, but, one of them was not registered, fixed the memory leak :D
|
Kudos, SonarCloud Quality Gate passed!
|
abrooksv
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ception during loading more (#1951)
Also fix the memory leak on close
Related Issue(s)
#1798
#1951
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.