telemetry: Code Scan Issue Fix diff usage #907
Conversation
| @@ -4398,6 +4408,34 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "name": "codewhisperer_codeScanIssueGenerateFixDiffUse", | |||
There was a problem hiding this comment.
there is already codewhisperer_codeScanIssueApplyFix . why can't "diff" be a field (name TBD) on that existing metric?
There was a problem hiding this comment.
Added the codeFixAction to codewhisperer_codeScanIssueApplyFix
| "acceptDiff", | ||
| "insertAtCursor", | ||
| "copyDiff" |
There was a problem hiding this comment.
Shouldn't this map to the buttons in the webview? If that's the case it should be openDiff instead of acceptDiff
There was a problem hiding this comment.
Corrected it and added quickFix as well to codeFixActions
| "required": false | ||
| }, | ||
| { | ||
| "type": "variant", |
There was a problem hiding this comment.
How will variant be used here?
There was a problem hiding this comment.
Not used anymore.
justinmk3
changed the title
| "openDiff", | ||
| "insertAtCursor", | ||
| "copyDiff", | ||
| "quickFix" |
There was a problem hiding this comment.
If I understand correctly, we will use codewhisperer_codeScanIssueApplyFix for both applying the fix and actions before applying the fix, is that right?
Co-authored-by: Tai Lai <[email protected]>
## Problem - `codeFixAction` in `codewhisperer_codeScanIssueApplyFix` event is marked as required. ## Solution - Updating `codeFixAction` in `codewhisperer_codeScanIssueApplyFix` event. - This change is related to this PR: #907
Problem
Need to record Telemetry when user is accepting code scan issue generated fix with three options of viewing code, inserting or copying it.
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.