Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant version file at core gem #1595

Merged
merged 2 commits into from
Sep 5, 2017
Merged

Conversation

cjyclaire
Copy link
Contributor

As described, address #1592

The core gem version is here, and extracted here

@cjyclaire cjyclaire requested a review from awood45 September 1, 2017 16:51
@cjyclaire
Copy link
Contributor Author

Added changelog entry, the only failure is the jruby hanging problem, which has been fixed and merged.
Merging this right now.

@cjyclaire cjyclaire closed this Sep 5, 2017
@cjyclaire cjyclaire reopened this Sep 5, 2017
@cjyclaire cjyclaire merged commit 5361c0c into master Sep 5, 2017
@cjyclaire cjyclaire deleted the remove-redundant branch September 5, 2017 18:44
@@ -1,3 +0,0 @@
module Aws
VERSION = '2.8.2'
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible side effect: thoughtbot/paperclip#2484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants