Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Supports pyarrow's large_list #3086

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix: Supports pyarrow's large_list #3086

merged 2 commits into from
Feb 4, 2025

Conversation

ashrielbrian
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Adds support for pyarrow's large_list to supported storage backends

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashrielbrian ashrielbrian changed the title Maps large_list to array fix: Maps large_list to array Feb 3, 2025
@ashrielbrian ashrielbrian changed the title fix: Maps large_list to array fix: Supports pyarrow's large_list Feb 3, 2025
@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 4d1daf1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 4d1daf1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido requested a review from kukushking February 3, 2025 13:21
@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: a77385d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

kukushking
kukushking approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but would be amazing to have a test case!

@jaidisido jaidisido linked an issue Feb 3, 2025 that may be closed by this pull request
awswrangler.s3.read_parquet_metadata does not support large_list datatype #3085
Closed
@kukushking kukushking merged commit 322ad04 into aws:main Feb 4, 2025
20 checks passed
@ashrielbrian ashrielbrian mentioned this pull request Feb 4, 2025
Merged
@ashrielbrian
Copy link
Contributor Author

hey @kukushking, i created a PR (#3089) with a simple test case for both large_string and large_list

@kukushking
Copy link
Contributor

Thanks @ashrielbrian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking approved these changes

@jaidisido jaidisido jaidisido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

awswrangler.s3.read_parquet_metadata does not support large_list datatype
3 participants
@ashrielbrian @jaidisido @kukushking