Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDb DocumentModel difficult to create stubs #604

Closed
lgrosales opened this issue Mar 31, 2017 · 4 comments
Closed

DynamoDb DocumentModel difficult to create stubs #604

lgrosales opened this issue Mar 31, 2017 · 4 comments
Labels
feature-request A feature should be added or improved.

Comments

@lgrosales
Copy link

lgrosales commented Mar 31, 2017

I'm finding the code using the DynamoDb DocumentModel (Table, Search, etc) difficult to test. Private constructors, no interfaces, impossible to create stubs of them.

Is there any plan to refactor these to make them more unit tests friendly?

@lgrosales lgrosales changed the title DocumentModel difficult to test DynamoDb DocumentModel difficult to test Mar 31, 2017
@lgrosales lgrosales changed the title DynamoDb DocumentModel difficult to test DynamoDb DocumentModel difficult to create stubs Mar 31, 2017
@PavelSafronov PavelSafronov added the feature-request A feature should be added or improved. label Mar 31, 2017
@PavelSafronov
Copy link

This isn't on our roadmap right now, but I will add it to our feature requests backlog.
If you're interested in working on this addition, we're always happy to accept a pull request.

PavelSafronov pushed a commit that referenced this issue Apr 3, 2017
@PavelSafronov
Copy link

Request added to backlog. Closing.

@Kralizek
Copy link
Contributor

I just stumbled on this very issue. Is there a way to vote up a feature request?

@kwbauer
Copy link

kwbauer commented Jan 14, 2020

This issue is fairly easily addressable by adding public constructors to the classes that are returned from the IDynamoDBContext methods. Either making the existing constructors public (only possible if their arguments are for public types) or adding another constructor (generally a parameterless one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

4 participants