fully unroll params in log message, don’t include hidden props

[bkw]

The current log messages do not include values for some nested structures because of the arguments chosen for util.inspect limit the depth.
In the case of DynamoDB.updateItem this leads to ExpressionAttributeValues being masked by [Object], for instance.

This PR changes the call to util.inspect to not include shadow properties (arg2 false, why would we want this?) and also set the depth to unlimited (arg3 null).

[coveralls]

Coverage remained the same when pulling 9665d17 on bkw:betterLogs into 2b463ce on aws:master.

[lsegal]

I'm okay with setting the depth to unlimited, but is there a reason why we wouldn't want to show non-enumerable properties? Keep in mind the SDK might be serializing these properties even if they are non-enumerable (there is no contract in the SDK to ignore non-enumerable properties when serializing a request), so in those cases we would not be logging data that was being serialized, which could be confusing. The opposing argument is that users could take advantage of non-enumerable properties to explicitly hide values from logging, but I'm not sure that's a pattern currently being used in the SDK.

I would opt to leave the enumerable behavior the way it is unless there's a reason to change it.

[bkw]

agreed, I just reenabled it.

[coveralls]

Coverage decreased (-0.2%) when pulling bc10498 on bkw:betterLogs into 2b463ce on aws:master.

[lsegal]

Thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.