Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "host" configuration to client-side monitoring configuration #2736

Merged
merged 2 commits into from
Jun 21, 2019

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Jun 20, 2019

/cc @cjyclaire

Checklist
  • npm run test passes
  • changelog is added, npm run add-change

@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #2736 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2736      +/-   ##
==========================================
+ Coverage   96.89%   96.89%   +<.01%     
==========================================
  Files         289      289              
  Lines        8755     8757       +2     
  Branches     1648     1651       +3     
==========================================
+ Hits         8483     8485       +2     
  Misses        272      272
Impacted Files Coverage Δ
lib/publisher/configuration.js 100% <100%> (ø) ⬆️
lib/publisher/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4466b1...9b14760. Read the comment docs.

@cjyclaire
Copy link

:shipit:

@AllanZhengYP AllanZhengYP merged commit 202d3d2 into aws:master Jun 21, 2019
@lock
Copy link

lock bot commented Jun 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants