Sqs AwsJson migration (#4105)

* Add awsQueryCompatible trait support to service When awsQueryCompatible trait is found, it's made available as an API property. When this property is found, the error code is returned by looking up the mapping. This is a pre-requisite for migrating services from AWSQuery wire protocol to AWSJson. * Add additional tests; review comments * Add awsQueryCompatible trait support to service When awsQueryCompatible trait is found, it's made available as an API property. When this property is found, the error code is returned by looking up the mapping. This is a pre-requisite for migrating services from AWSQuery wire protocol to AWSJson. * Add additional tests; review comments * Review comments * Use MockServiceFromApi; Move errorCodeMapping logic to even)listeners * Update on.error function * Fix type * Remove reimplementation of mapping function * Use add instead of addAsync Co-authored-by: AllanZhengYP <[email protected]> * Add null check to error listener * Use simple service null check * Fix add 'Error' implementation * Add changelog Co-authored-by: AllanZhengYP <[email protected]>
aws · Jun 29, 2022 · 2a87ec1 · 2a87ec1
1 parent d4a4f4a
commit 2a87ec1
Show file tree

Hide file tree

Showing 5 changed files with 90 additions and 13 deletions.
diff --git a/.changes/next-release/feature-AwsQueryCompatible-50f5060a.json b/.changes/next-release/feature-AwsQueryCompatible-50f5060a.json
@@ -0,0 +1,5 @@
+{
+  "type": "feature",
+  "category": "AwsQueryCompatible",
+  "description": "Add awsQueryCompatible trait support to service"
+}
diff --git a/lib/event_listeners.js b/lib/event_listeners.js
@@ -299,6 +299,16 @@ AWS.EventListeners = {
       }
     });
 
+    add('ERROR', 'error', function ERROR(err, resp) {
+      var errorCodeMapping = resp.request.service.api.errorCodeMapping;
+      if (errorCodeMapping && err && err.code) {
+        var mapping = errorCodeMapping[err.code];
+        if (mapping) {
+          resp.error.code = mapping.code;
+        }
+      }
+    }, true);
+
     addAsync('SEND', 'send', function SEND(resp, done) {
       resp.httpResponse._abortCallback = done;
       resp.error = null;

diff --git a/lib/model/api.js b/lib/model/api.js
@@ -80,6 +80,7 @@ function Api(api, options) {
     property(this, 'documentation', api.documentation);
     property(this, 'documentationUrl', api.documentationUrl);
   }
+  property(this, 'errorCodeMapping', api.awsQueryCompatible);
 }
 
 /**

diff --git a/test/helpers.js b/test/helpers.js
diff --git a/test/service.spec.js b/test/service.spec.js
-Original file line number
+Diff line change
@@ Expand Up / @@ -80,6 +80,7 @@ function Api(api, options) { @@
         property(this, 'documentation', api.documentation);
         property(this, 'documentationUrl', api.documentationUrl);
       }
+      property(this, 'errorCodeMapping', api.awsQueryCompatible);
     }
     /**
@@ Expand Down @@