Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): update codegen for exactOptionalPropertyTypes #6654

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 12, 2024

codegen sync to support exactOptionalPropertyTypes

closes #4017

@kuhe kuhe requested a review from a team as a code owner November 12, 2024 21:13
@kuhe kuhe merged commit 4817524 into aws:main Nov 12, 2024
4 checks passed
@kuhe kuhe deleted the chore/codegen branch November 12, 2024 21:37
monholm added a commit to monholm/aws-sdk-js-v3 that referenced this pull request Nov 19, 2024
aws#6654 added `| undefined` to optional model props, but the types in lib-dynamodb wasn't updated to
reflect that change. This leaves consumers using `exactOptionalPropertyTypes: true` with ts errors
when trying to use almost any of the commands in lib-dynamodb

Fixes aws#6668
kuhe added a commit that referenced this pull request Nov 20, 2024
* fix(lib-dynamodb): input types conflicts with client-dynamodb

#6654 added `| undefined` to optional model props, but the types in lib-dynamodb wasn't updated to
reflect that change. This leaves consumers using `exactOptionalPropertyTypes: true` with ts errors
when trying to use almost any of the commands in lib-dynamodb

Fixes #6668

* fix(lib-dynamodb): support exactOptionalPropertyTypes

---------

Co-authored-by: monholm <[email protected]>
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for exactOptionalPropertyTypes
2 participants