Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aws-restjson-*): use vitest #6628

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 5, 2024

Issue

Refs: #6627 (comment)

Description

Uses vitest for running unit tests in aws-restjson-*

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review November 5, 2024 22:47
@trivikr trivikr requested a review from a team as a code owner November 5, 2024 22:47
@kuhe
Copy link
Contributor

kuhe commented Nov 6, 2024

needs codegen update in smithy-ts?

@trivikr
Copy link
Member Author

trivikr commented Nov 6, 2024

No. The codegen had updated aws-rest-json-* clients, but it was removed in b6b04de (#6627)

@kuhe kuhe merged commit ea3482f into aws:main Nov 7, 2024
4 checks passed
@trivikr trivikr deleted the vitest-aws-restjson branch November 7, 2024 16:20
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants