chore(credential-providers): add credential attribution #6546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
chore/features-credentials
branch
from
ce8eb61 to
fea98a1
Compare
kuhe
force-pushed
the
chore/features-credentials
branch
from
fea98a1 to
834aa7a
Compare
trivikr
approved these changes
Oct 7, 2024
| * | ||
| * @returns the credentials with source feature attribution. | ||
| */ | ||
| export function setCredentialFeature<F extends keyof AwsSdkCredentialsFeatures>( |
There was a problem hiding this comment.
nit: move to a new file setCredentialFeature?
There was a problem hiding this comment.
done, added unit tests
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
Adds feature detection for credential sources, with the exceptions of:
which will be completed later due to needing further customization.
Testing