Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use yarn for running turbo commands #6480

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 16, 2024

Issue

N/A, we use yarn for running all commands

Description

Use yarn for running turbo commands

Testing

Before

$ yarn build:all
yarn run v1.22.22
$ node ./scripts/turbo build
turbo 2.1.2

• Packages in scope: @aws-sdk/aws-client-api-test, ...
...
 Tasks:    473 successful, 473 total
Cached:    473 cached, 473 total
  Time:    23.98s >>> FULL TURBO

Done in 24.73s.

After

$ yarn build:all
yarn run v1.22.22
$ node ./scripts/turbo build
$ /local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/.bin/turbo run build --concurrency=100% --output-logs=hash-only
turbo 2.1.2

• Packages in scope: @aws-sdk/aws-client-api-test, ...
...
 Tasks:    473 successful, 473 total
Cached:    473 cached, 473 total
  Time:    23.701s >>> FULL TURBO

Done in 24.30s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner September 16, 2024 20:06
@trivikr trivikr merged commit cd53ac9 into aws:main Sep 16, 2024
4 checks passed
@trivikr trivikr deleted the run-turbo-with-yarn branch September 16, 2024 20:23
RanVaknin pushed a commit to RanVaknin/aws-sdk-js-v3 that referenced this pull request Sep 21, 2024
Copy link

github-actions bot commented Oct 3, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants