Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show only turbo-computed task hashes in output #6478

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 16, 2024

Issue

N/A

Description

Limits turbo output to only turbo-computed task hashes

Testing

Before

The default full output is around 6K lines
turbo-output-full.txt

After

The hash-only output is around 485 lines
turbo-output-hash-only.txt


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner September 16, 2024 15:21
@trivikr
Copy link
Member Author

trivikr commented Sep 16, 2024

Verified that errors are emitted in case of build failures

Example syntax error in @aws-sdk/body-checksum-browser

$ yarn build:all
...
 Tasks:    457 successful, 458 total
Cached:    457 cached, 458 total
  Time:    23.56s 
Failed:    @aws-sdk/body-checksum-browser#build

 ERROR  run failed: command  exited (1)
Error running turbo: npx failed with { code: 1, signal: null }
$ yarn build:all | grep body-checksum-browser
...
@aws-sdk/body-checksum-browser:build: cache miss, executing 30879760a251abd5
@aws-sdk/body-checksum-browser:build: yarn run v1.22.13
@aws-sdk/body-checksum-browser:build: $ concurrently 'yarn:build:cjs' 'yarn:build:es' 'yarn:build:types'
@aws-sdk/body-checksum-browser:build: [build:es] $ tsc -p tsconfig.es.json
@aws-sdk/body-checksum-browser:build: [build:cjs] $ node ../../scripts/compilation/inline body-checksum-browser
@aws-sdk/body-checksum-browser:build: [build:types] $ tsc -p tsconfig.types.json
@aws-sdk/body-checksum-browser:build: [build:cjs] $ /local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/.bin/rimraf ./dist-cjs tsconfig.cjs.tsbuildinfo
@aws-sdk/body-checksum-browser:build: [build:cjs] $ /local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/.bin/tsc -p tsconfig.cjs.json
@aws-sdk/body-checksum-browser:build: [build:es] src/index.ts(42,1): error TS1005: '}' expected.
@aws-sdk/body-checksum-browser:build: [build:types] src/index.ts(42,1): error TS1005: '}' expected.
@aws-sdk/body-checksum-browser:build: [build:es] error Command failed with exit code 2.
@aws-sdk/body-checksum-browser:build: [build:es] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@aws-sdk/body-checksum-browser:build: [build:types] error Command failed with exit code 2.
@aws-sdk/body-checksum-browser:build: [build:types] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@aws-sdk/body-checksum-browser:build: [build:types] yarn run build:types exited with code 2
@aws-sdk/body-checksum-browser:build: [build:es] yarn run build:es exited with code 2
@aws-sdk/body-checksum-browser:build: [build:cjs] src/index.ts(42,1): error TS1005: '}' expected.
@aws-sdk/body-checksum-browser:build: [build:cjs] error Command failed with exit code 2.
@aws-sdk/body-checksum-browser:build: [build:cjs] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@aws-sdk/body-checksum-browser:build: [build:cjs] node:internal/process/promises:288
@aws-sdk/body-checksum-browser:build: [build:cjs]             triggerUncaughtException(err, true /* fromPromise */);
@aws-sdk/body-checksum-browser:build: [build:cjs]             ^
@aws-sdk/body-checksum-browser:build: [build:cjs] 
@aws-sdk/body-checksum-browser:build: [build:cjs] [UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "yarn failed with { code: 2, signal: null }".] {
@aws-sdk/body-checksum-browser:build: [build:cjs]   code: 'ERR_UNHANDLED_REJECTION'
@aws-sdk/body-checksum-browser:build: [build:cjs] }
@aws-sdk/body-checksum-browser:build: [build:cjs] 
@aws-sdk/body-checksum-browser:build: [build:cjs] Node.js v18.20.2
@aws-sdk/body-checksum-browser:build: [build:cjs] error Command failed with exit code 1.
@aws-sdk/body-checksum-browser:build: [build:cjs] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@aws-sdk/body-checksum-browser:build: [build:cjs] yarn run build:cjs exited with code 1
@aws-sdk/body-checksum-browser:build: error Command failed with exit code 1.
@aws-sdk/body-checksum-browser:build: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@aws-sdk/body-checksum-browser:build: ERROR: command finished with error: command (/local/home/trivikr/workspace/aws-sdk-js-v3/packages/body-checksum-browser) /local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/.bin/yarn run build exited (1)
@aws-sdk/body-checksum-browser#build: command (/local/home/trivikr/workspace/aws-sdk-js-v3/packages/body-checksum-browser) /local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/.bin/yarn run build exited (1)
Failed:    @aws-sdk/body-checksum-browser#build
 ERROR  run failed: command  exited (1)
Error running turbo: npx failed with { code: 1, signal: null }

@trivikr trivikr force-pushed the turbo-output-hash-only branch from cd95853 to 8f600a3 Compare September 16, 2024 19:38
@trivikr trivikr force-pushed the turbo-output-hash-only branch from 8f600a3 to cb24838 Compare September 16, 2024 19:42
@trivikr trivikr merged commit f8befa6 into aws:main Sep 16, 2024
4 checks passed
@trivikr trivikr deleted the turbo-output-hash-only branch September 16, 2024 19:56
RanVaknin pushed a commit to RanVaknin/aws-sdk-js-v3 that referenced this pull request Sep 21, 2024
Copy link

github-actions bot commented Oct 3, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants