Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): pass through sha256 in non-AWS sigv4 generated client #6415

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Aug 27, 2024

Issue

n/a

Description

  • converts the example Weather service client to have a protocol (restjson1). This makes it easier to test in integration mode.
  • fix: pass through the sha256 ctor impl from config to signingProperties for non-AWS sigv4 services. This is the diff in httpAuthSchemeProvider.ts in weather/src/auth.

Testing

Added new integration test stub for the "Weather" example client.

  • yarn test:protocols

@kuhe kuhe requested a review from a team as a code owner August 27, 2024 19:34
@kuhe kuhe merged commit 0a561ee into aws:main Aug 28, 2024
5 checks passed
@kuhe kuhe deleted the fix/codegen branch August 28, 2024 17:09
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants