Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib-dynamodb): use pagination factory from core #6345

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

pasoevi
Copy link
Contributor

@pasoevi pasoevi commented Aug 1, 2024

Description

Use pagination factory function (createPaginator) from @smithy/core

Testing

yarn test in lib/lib-dynamodb - all tests pass
yarn test:e2e in lib/lib-dynamodb - all tests pass

Additional context

Used #5590 for reference

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O? N/A
  • If adding new public functions, did you add the @public tag and enable doc generation on the package? N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pasoevi pasoevi force-pushed the pasoevi-chore-ddb-use-paginator-factory branch from 671f12c to be572a0 Compare August 1, 2024 16:18
@pasoevi pasoevi force-pushed the pasoevi-chore-ddb-use-paginator-factory branch from be572a0 to d036757 Compare August 1, 2024 16:47
@pasoevi pasoevi changed the title Pasoevi chore ddb use paginator factory chore(codegen): use pagination factory in ddb document client Aug 1, 2024
@pasoevi pasoevi marked this pull request as ready for review August 1, 2024 17:08
@pasoevi pasoevi requested a review from a team as a code owner August 1, 2024 17:08
@trivikr trivikr changed the title chore(codegen): use pagination factory in ddb document client chore(lib-dynamodb): use pagination factory from core Aug 1, 2024
@trivikr trivikr merged commit 922292b into aws:main Aug 1, 2024
5 checks passed
@pasoevi pasoevi deleted the pasoevi-chore-ddb-use-paginator-factory branch August 6, 2024 11:17
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants