Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): bump smithy-typescript version to 0.21.1 #6170

Closed
wants to merge 1 commit into from

Conversation

kstich
Copy link
Contributor

@kstich kstich commented Jun 6, 2024

Code generation diff: b471e06

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kstich kstich requested a review from a team as a code owner June 6, 2024 05:20
@@ -1,7 +1,7 @@
// Update this commit when taking up new changes from smithy-typescript.
module.exports = {
// Use full commit hash as we explicitly fetch it.
SMITHY_TS_COMMIT: "05b2fb2f92af20e824cc71ed4490ed0c7075964e",
SMITHY_TS_COMMIT: "25726c12c40479b73c2919c56e2ce8c41e2a22d6",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kstich kstich force-pushed the smithy-ts-update-0-21-1 branch from 4b5244a to 063522f Compare June 6, 2024 05:34
@@ -1,7 +1,7 @@
// Update this commit when taking up new changes from smithy-typescript.
module.exports = {
// Use full commit hash as we explicitly fetch it.
SMITHY_TS_COMMIT: "05b2fb2f92af20e824cc71ed4490ed0c7075964e",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit 25726c12c40479b73c2919c56e2ce8c41e2a22d6 is from bump-0.21.1 branch. We need to bump from merged commit in mainline, which is cf9d6fe3483ba027f98e87d1921c32dd94e2c1f9

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The export type change was merged in #6171

@trivikr
Copy link
Member

trivikr commented Jun 6, 2024

Merged in #6172

@trivikr trivikr closed this Jun 6, 2024
@trivikr trivikr deleted the smithy-ts-update-0-21-1 branch June 6, 2024 15:25
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants