Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credential-providers): use pinned version for client peerDependencies #6060

Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 3, 2024

Issue

Fixes: #6059

Description

Uses pinned version for client peerDependencies in credential providers

Testing

$ yarn update:versions:current

$ git diff --stat | tail -n1
 457 files changed, 5261 insertions(+), 5261 deletions(-)

Credential providers have exact dependencies

$ grep -rnI -A 2 peerDependencies packages/credential-provider-ini/package.json
46:  "peerDependencies": {
47-    "@aws-sdk/client-sts": "3.568.0"
48-  },

$ grep -rnI -A 2 peerDependencies packages/credential-provider-web-identity/package.json 
48:  "peerDependencies": {
49-    "@aws-sdk/client-sts": "3.568.0"
50-  },

$ grep -rnI -A 2 peerDependencies packages/token-providers/package.json 
43:  "peerDependencies": {
44-    "@aws-sdk/client-sso-oidc": "3.568.0"
45-  },

Other peerDependencies are caret versions

$ grep -rnI -A 2 peerDependencies lib/*/package.json 
lib/lib-dynamodb/package.json:34:  "peerDependencies": {
lib/lib-dynamodb/package.json-35-    "@aws-sdk/client-dynamodb": "^3.568.0"
lib/lib-dynamodb/package.json-36-  },
--
lib/lib-storage/package.json:37:  "peerDependencies": {
lib/lib-storage/package.json-38-    "@aws-sdk/client-s3": "^3.568.0"
lib/lib-storage/package.json-39-  },
$ yarn update:versions:default

$ git diff --stat | tail -n1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the use-strict-version-credential-provider-deps branch from e6f202a to cff6ff6 Compare May 3, 2024 19:24
@trivikr trivikr force-pushed the use-strict-version-credential-provider-deps branch from 3621d3b to 138fcc7 Compare May 3, 2024 19:52
@trivikr trivikr marked this pull request as ready for review May 3, 2024 19:55
@trivikr trivikr requested a review from a team as a code owner May 3, 2024 19:55
@trivikr trivikr changed the title chore(credential-providers): use pinned version for client peerDependencies fix(credential-providers): use pinned version for client peerDependencies May 3, 2024
@trivikr trivikr merged commit 20098c1 into aws:main May 3, 2024
5 checks passed
@trivikr trivikr deleted the use-strict-version-credential-provider-deps branch May 15, 2024 16:11
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install size of node_modules increased in v3.565.0
2 participants