fix(middleware-ssec): ssecMiddleware with strict base64 validation #5875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#5863
Description
Making a a more robust check for if the provided key is indeed a base64 by comparing the byte length to 32, since AES-256 specifies a cipher must be 256bits (32 bytes) we can assert that the cipher provided must have a byte length of 32.
https://csrc.nist.gov/pubs/fips/197/final
Testing
Added unit test coverage to cover the more of the middleware changes from #5676
And additionally unit tests to cover the
isValidBase64EncodedSSECustomerKey
helper function.Driver code:
Borrowed from edge case mentioned in #5863:
Additional context
Add any other context about the PR here.
Checklist
@public
tag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.