fix(s3-request-presigner): identify correct authscheme for mrap #5742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#5639
Description
This pull request addresses an issue where the signing region for a presigned URL was not being set correctly when using a Multi-Region Access Point (MRAP) with the auth scheme SigV4a. Previously, when an MRAP was specified as a bucket, the signing region would be left as
undefined
. This resulted in presigned URLs that did not conform to the expected SigV4a specifications, where the signing region should be set to "*" to indicate a multi-region signing process.To resolve this, I have updated the logic for determining the signing region within the getSignedUrl function. Now, when the provided bucket is an MRAP, the SDK correctly deduces that the auth scheme is SigV4a and sets the signing region to "". This ensures that the generated presigned URL uses the correct signing algorithm (AWS4-ECDSA-P256-SHA256) and includes the X-Amz-Region-Set parameter set to "".
Example:
Driver code:
Output (URL Decoded and formatted for better readability):
Before changes:
After changes: