Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): rename aws-sdk dir to aws_sdk #5598

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

syall
Copy link
Contributor

@syall syall commented Dec 18, 2023

Issue

Issue number, if available, prefixed with "#"

Closes: #5594.

Description

What does this implement/fix? Explain your changes.

Rename aws-sdk dir to aws_sdk.

Testing

How was this change tested?

CI passes.

Additional context

Add any other context about the PR here.

N/A.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@syall syall marked this pull request as ready for review December 18, 2023 18:46
@syall syall requested a review from a team as a code owner December 18, 2023 18:46
@syall syall merged commit 101d414 into aws:main Dec 18, 2023
3 checks passed
@syall syall deleted the rename-core-aws-sdk-directory branch December 18, 2023 20:31
Copy link

github-actions bot commented Jan 2, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module './aws-sdk' on v3.474.0 of @aws-sdk/credential-provider-node
3 participants