Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): use md5-js from @smithy #4967

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jul 14, 2023

Issue

Issue number, if available, prefixed with "#"

Description

Use @smithy/md5-js instead of @aws-sdk/md5-js. The md5-js package was migrated to @smithy and this should've been switched over previously.

Testing

How was this change tested?

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase marked this pull request as ready for review July 14, 2023 19:29
@srchase srchase requested a review from a team as a code owner July 14, 2023 19:29
@@ -136,14 +136,14 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
case BROWSER:
return MapUtils.of(
"streamHasher", writer -> {
writer.addDependency(AwsDependency.STREAM_HASHER_BROWSER);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has this been marked deprecated?

@srchase srchase merged commit 609ba60 into aws:main Jul 19, 2023
@srchase srchase deleted the use-smithy-md5-browser branch July 19, 2023 16:19
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants