Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hash-blob-browser): add back missing dep #4932

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

milesziemer
Copy link
Contributor

Issue

Issue number, if available, prefixed with "#"

#4631

Description

What does this implement/fix? Explain your changes.

Adds back the chunked-blob-reader-native dependency. It was removed in #4571 because it wasn't being used in the TS code anywhere, but it is depended on in the package.json here.

Testing

How was this change tested?

CI

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@milesziemer milesziemer requested review from a team as code owners July 6, 2023 14:58
Adds back the chunked-blob-reader-native dependency. It was removed
in aws#4571 because it
wasn't being used in the TS code anywhere, but it is depended on
in the package.json.
@milesziemer milesziemer force-pushed the fix-missing-dep-hash-blob-browser branch from bd5fca8 to cac9a67 Compare July 6, 2023 15:01
@kuhe kuhe merged commit 0f3c27f into aws:main Jul 6, 2023
@kuhe
Copy link
Contributor

kuhe commented Jul 6, 2023

there will be an equivalent PR in the smithy-typescript repo

@milesziemer
Copy link
Contributor Author

smithy-typescript change: smithy-lang/smithy-typescript#810

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants