Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-middleware-test): skip all build steps #4917

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 3, 2023

Issue

Internal JS-4460

Description

The internal builds are failing with the following error:

$ tsc -p tsconfig.types.json
tsconfig.types.json(2,14): error TS6053: File './tsconfig' not found.
../aws-util-test/src/requests/test-http-handler.ts(169,35): error TS2802: Type 'Map<string | RegExp, Matcher> | [string, Matcher][]' can only be iterated through when using the '--downlevelIteration' flag or with a '--target' of 'es2015' or higher.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run build:types stderr:
error Command failed with exit code 2.
lerna ERR! yarn run build:types exited 2 in '@aws-sdk/aws-middleware-test'

This PR removes all build steps from the package

Testing

Verified that all builds (if attempted), are successful in aws-middleware-test

$ aws-middleware-test> yarn build
yarn run v1.22.17
$ exit 0
Done in 0.06s.

$ aws-middleware-test> yarn build:types
yarn run v1.22.17
$ exit 0
Done in 0.06s.

$ aws-middleware-test> yarn build:types:downlevel
yarn run v1.22.17
$ exit 0
Done in 0.06s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner July 3, 2023 20:44
@trivikr trivikr merged commit b97df31 into aws:main Jul 3, 2023
@trivikr trivikr deleted the remove-build-aws-middleware-test branch July 3, 2023 20:47
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants