fix(codegen): remove deprecated packages from sdkVersions.properties #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
approved these changes
Jun 29, 2023
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
Description
Currently, the
sdkVersions.propertiesresource file is generated with the current version of each client and dependency package including packages that have been deprecated.For example,
karma-credential-loaderhas been deprecated and the last published version was3.40.0: https://www.npmjs.com/package/@aws-sdk/karma-credential-loaderHowever, the
sdkVersions.propertiesresource file is currently being generated with this line:This PR updates build.gradle.kts to exclude packages which have been deprecated by setting
private: truein their package.json.Testing
Ran
./gradlew clean buildfrom the/codegendirectory and confirmed that the generate file at/codegen/smithy-aws-typescript-codegen/build/resources/main/software/amazon/smithy/aws/typescript/codegen/sdkVersions.propertiesno longer included a line forkarma-credential-loader.Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.