Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): use lerna from yarn instead of node_modules #4835

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 13, 2023

Issue

Testing if Benchmark test hanging in Ubuntu Standard 6.0+ is related to lerna being called from node_modules

Description

Uses lerna from yarn instead of node_modules for running benchmark

Testing

Verified that Benchmark size tests, which use verdaccio, are successful:

$ yarn test:size --since last_release
...
Report is updated, validating the new result with the limit configurations.
Done in 159.05s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review August 9, 2023 20:24
@trivikr trivikr requested a review from a team as a code owner August 9, 2023 20:24
@siddsriv siddsriv merged commit bd9cff7 into aws:main Aug 9, 2023
@trivikr trivikr deleted the benchmark-size-lerna-from-yarn branch August 9, 2023 21:50
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants