chore(credential-providers): use .browser extension for index #3519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
We use
.browser.ts
as an extension for browser specific JS code, and.native.ts
extension for react-native specific JS code if it's different from that in the browser.The primary reason for using "browser.ts" could have been due to
"browser"
configuration in package.jsonThe
.web.ts
extension in credential-providers could have been created as it's used in browser as well as react-native. I we want to follow this standard, the packages which are used across browser and react-native will need to be renamed to use-web
- like@aws-sdk/util-utf8-browser
or@aws-sdk/util-base64-browser
, or the packages with-native
suffix need to be created which re-exports-browser
.This suggestive PR renames
.web.ts
to.browser.ts
which is one of the options.Testing
Verified that
index.browser.js
is transpiled indist-es
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.