chore(clients): set default parameter for ClientConfig #3416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
force-pushed
the
empty-hash-default-param-client-constructor
branch
from
d47fed0 to
a7f3c31
Compare
|
Error with EchoService src/EchoServiceClient.ts(205,15): error TS2322: Type '{}' is not assignable to type 'EchoServiceClientConfig'.
Property 'endpoint' is missing in type '{}' but required in type 'CustomEndpointsInputConfig'.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
yarn run build:es exited with code 2 |
trivikr
force-pushed
the
empty-hash-default-param-client-constructor
branch
from
a7f3c31 to
8ccd134
Compare
|
Replaced by #5060 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Refs smithy-lang/smithy-typescript#525
Description
Sets default parameter for ClientConfig in constructor as empty object
Testing
ToDo: Verify that TypeScript allows client creation with no parameters
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.