-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(credential-provider-sso): support resolving credentials from SSO token #2055
Conversation
ca0c67d
to
10278e3
Compare
c4c4c63
to
c5ca50e
Compare
The Codebuild fails when running yarn install v1.22.5
37 | [1/4] Resolving packages...
38 | [2/4] Fetching packages...
39 | info [email protected]: The platform "linux" is incompatible with this module.
40 | info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
41 | info [email protected]: The platform "linux" is incompatible with this module.
42 | info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
43 | [3/4] Linking dependencies...
44 | warning "lerna > @lerna/version > @lerna/github-client > @octokit/rest > @octokit/[email protected]" has unmet peer dependency "@octokit/core@>=3".
45 | warning " > [email protected]" has unmet peer dependency "typedoc@^0.17.0".
46 | warning "workspace-aggregator-27c30dae-4809-4a7d-9a4d-7daa3bf2385f > @aws-sdk/client-kafka > [email protected]" has incorrect peer dependency "[email protected] \|\| 4.0.x".
47 | warning "workspace-aggregator-27c30dae-4809-4a7d-9a4d-7daa3bf2385f > @aws-sdk/middleware-retry > [email protected]" has unmet peer dependency "react-native@>=0.56".
48 | error An unexpected error occurred: "ENOENT: no such file or directory, lstat '/codebuild/output/src829467270/src/github.com/aws/aws-sdk-js-v3/clients/client-sso/node_modules/@types'".
49 | info If you think this is a bug, please open a bug report with the information provided in "/codebuild/output/src829467270/src/github.com/aws/aws-sdk-js-v3/yarn-error.log".
50 | info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
51 I cannot reproduce it on my machine. It very wierd that the error will gone if run |
The root cause is still unclear. But changing to not hoisting the |
c5ca50e
to
6720cbf
Compare
Yarn install would fail with client-sso/node_modules/@type no exist if hoisted.
Codecov Report
@@ Coverage Diff @@
## main #2055 +/- ##
=======================================
Coverage ? 79.51%
=======================================
Files ? 367
Lines ? 15369
Branches ? 3319
=======================================
Hits ? 12220
Misses ? 3149
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments.
Co-authored-by: Trivikram Kamat <[email protected]>
848bd1b
to
afa15e6
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Resolves: #1158
Description
Add a credential provider that resolves the cached SSO token by cli-configure-sso
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.