Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-kinesis-video-signaling): remove retry headers #1963

Merged
merged 3 commits into from
Feb 16, 2021

Conversation

pdcarroll
Copy link
Contributor

@pdcarroll pdcarroll commented Jan 27, 2021

Issue #, if available:
Fixes: #1962

Description of changes:
Use getOmitRetryHeadersPlugin in KinesisVideoSignalingClient

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Service name "Kinesis Video Signaling" needs to be added under SERVICE_IDS in AddOmitRetryHeadersDependency.java

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: e08f9eb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 8b35943 into aws:master Feb 16, 2021
@github-actions
Copy link

github-actions bot commented Mar 3, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kinesis video signaling GetIceServerConfigCommand blocked by CORS policy
3 participants