Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(credential-provider-node): behavior when roleAssumer is not provided #1950

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

dmattia
Copy link
Contributor

@dmattia dmattia commented Jan 22, 2021

No description provided.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 1f61b95
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Base automatically changed from master to main February 22, 2021 19:46
@dmattia dmattia requested a review from a team as a code owner January 28, 2022 23:34
@trivikr trivikr self-assigned this Aug 9, 2023
@trivikr
Copy link
Member

trivikr commented Aug 9, 2023

Todo: verify if the documentation needs to be updated, and create new PR.

@trivikr
Copy link
Member

trivikr commented Aug 17, 2023

verify if the documentation needs to be updated

Verified that error is thrown when roleAssumer is not provided.

if (!options.roleAssumer) {
throw new CredentialsProviderError(
`Profile ${profileName} requires a role to be assumed, but no role assumption callback was provided.`,
false
);
}

The SDK clients provide a default role assumer, but this documentation if for anyone using the credential provider directly.

@trivikr trivikr changed the title Fix incorrect statement in node credential provider docs(credential-provider-node): behavior when roleAssumer is not provided Aug 17, 2023
@trivikr trivikr merged commit 015cd79 into aws:main Aug 17, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants