-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(url-parser-node): use WHATWG URL instead of url.parse #1766
Conversation
url.parse has been deprecated and it recommends using the WHATWG URL API https://nodejs.org/api/url.html#url_url_parse_urlstring_parsequerystring_slashesdenotehost WHATWG URL has been available on Global Object since v10.0.0 https://nodejs.org/api/url.html#url_the_whatwg_url_api
Codecov Report
@@ Coverage Diff @@
## master #1766 +/- ##
==========================================
+ Coverage 79.77% 79.83% +0.05%
==========================================
Files 325 336 +11
Lines 12087 12620 +533
Branches 2553 2679 +126
==========================================
+ Hits 9643 10075 +432
- Misses 2444 2545 +101
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the change I'd like to do!
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Resolves: #999
Description of changes:
use WHATWG URL instead of url.parse
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.