fix(node-http-handler): set maxSockets above 0 in test #1660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1539
Description of changes:
Just browsing, but it looks at first glance like the issue with the test is that
maxSockets
will sometimes be set to 0 – due to Math.random() and Math.round(). My guess is that a setting ofmaxSockets = 0
gets turned intoInfinity
– so the test will fail in these cases. This change ensuresmaxSockets
will always be at least1
in this test.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.