Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credential-provider-cognito-identity): return identityId as part of cognitoIdentityPool #1635

Merged
merged 2 commits into from
Oct 28, 2020
Merged

fix(credential-provider-cognito-identity): return identityId as part of cognitoIdentityPool #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17c8518
fix: propogate identityId from cognito identity
alexforsyth Oct 28, 2020
d884329
fix: update test
alexforsyth Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/credential-provider-cognito-identity/src/fromCognitoIdentity.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ describe("fromCognitoIdentity", () => {
customRoleArn: "myArn",
})()
).toEqual({
identityId: identityId,
accessKeyId: "foo",
secretAccessKey: "bar",
sessionToken: "baz",
Expand Down
10 changes: 9 additions & 1 deletion packages/credential-provider-cognito-identity/src/fromCognitoIdentity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,21 @@ import { CredentialProvider, Credentials } from "@aws-sdk/types";
import { CognitoProviderParameters } from "./CognitoProviderParameters";
import { resolveLogins } from "./resolveLogins";

export interface CognitoIdentityCredentials extends Credentials {
/**
* The Cognito ID returned by the last call to AWS.CognitoIdentity.getOpenIdToken().
*/
identityId: string;
}

/**
* Retrieves temporary AWS credentials using Amazon Cognito's
* `GetCredentialsForIdentity` operation.
*
* Results from this function call are not cached internally.
*/
export function fromCognitoIdentity(parameters: FromCognitoIdentityParameters): CredentialProvider {
return async (): Promise<Credentials> => {
return async (): Promise<CognitoIdentityCredentials> => {
const {
Credentials: {
AccessKeyId = throwOnMissingAccessKeyId(),
Expand All @@ -29,6 +36,7 @@ export function fromCognitoIdentity(parameters: FromCognitoIdentityParameters):
);

return {
identityId: parameters.identityId,
accessKeyId: AccessKeyId,
secretAccessKey: SecretKey,
sessionToken: SessionToken,
Expand Down