fix: apply review feedbacks

Co-authored-by: Attila Večerek <[email protected]>

packages/s3-request-presigner/README.md

@@ -86,7 +86,7 @@ If your request contains server-side encryption(`x-amz-server-side-encryption*`)
 headers, because of S3 limitation, you need to send these headers along
 with the presigned url. That is to say, the url only from calling `formatUrl()`
 to `presigned` is not sufficient to make a request. You need to send the
-server-side encryption headers along with url. These headers remain in the
+server-side encryption headers along with the url. These headers remain in the
 `presigned.headers`
 
 For more information, please go to [S3 SSE reference](https://docs.aws.amazon.com/AmazonS3/latest/dev/KMSUsingRESTAPI.html)

packages/s3-request-presigner/src/presigner.spec.ts

@@ -95,11 +95,16 @@ describe("s3 presigner", () => {
       headers: {
         ...minimalRequest.headers,
         "x-amz-server-side-encryption": "kms",
+        "x-amz-server-side-encryption-customer-algorithm": "AES256",
       },
     });
     expect(signed.headers).toMatchObject({
       "x-amz-server-side-encryption": "kms",
     });
-    expect(signed.query?.["X-Amz-SignedHeaders"]).toEqual(expect.stringContaining("x-amz-server-side-encryption"));
+    const signedHeadersHeader = signed.query?.["X-Amz-SignedHeaders"];
+    const signedHeaders =
+      typeof signedHeadersHeader === "string" ? signedHeadersHeader.split(";") : signedHeadersHeader;
+    expect(signedHeaders).toContain("x-amz-server-side-encryption");
+    expect(signedHeaders).toContain("x-amz-server-side-encryption-customer-algorithm");
   });
 });

packages/types/src/signature.ts

@@ -54,9 +54,9 @@ export interface RequestPresigningArguments extends RequestSigningArguments {
   expiresIn?: number;
 
   /**
-   * A set of string whose members represents headers that should not be hoisted
-   * to presigned request's query string. If not supplied, the presigner will
-   * move all the AWS-specific headers(starting with `x-amz-`) to the request
+   * A set of strings whose representing headers that should not be hoisted
+   * to presigned request's query string. If not supplied, the presigner
+   * moves all the AWS-specific headers (starting with `x-amz-`) to the request
    * query string. If supplied, these headers remain in the presigned request's
    * header.
    * All headers in the provided request will have their names converted to