Skip to content

Commit

Permalink
fix(polly-request-presigner): override middleware name to allow concu…
Browse files Browse the repository at this point in the history
…rrent presigning (#6335)

Co-authored-by: RanVaknin <[email protected]>
  • Loading branch information
RanVaknin and RanVaknin authored Jul 30, 2024
1 parent 197bc7d commit 54990fa
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
14 changes: 14 additions & 0 deletions packages/polly-request-presigner/src/getSignedUrls.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,18 @@ describe("getSignedUrl", () => {
expect(mockPresign).toBeCalled();
expect(mockPresign.mock.calls[0][1]).toMatchObject(options);
});
it("should not throw if called concurrently", async () => {
const mockPresigned = "a presigned url";
mockPresign.mockReturnValue(mockPresigned);
const client = new PollyClient(clientParams);
const command = new SynthesizeSpeechCommand({
Text: "hello world, this is alex",
OutputFormat: "mp3",
VoiceId: "Kimberly",
});
const result = await Promise.all([getSignedUrl(client, command), getSignedUrl(client, command)]);
expect(result).toBeInstanceOf(Array);
expect(result).toHaveLength(2);
expect(mockPresign).toHaveBeenCalledTimes(2);
});
});
1 change: 1 addition & 0 deletions packages/polly-request-presigner/src/getSignedUrls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export const getSignedUrl = async (
name: "presignInterceptMiddleware",
relation: "before",
toMiddleware: "awsAuthMiddleware",
override: true,
});

let presigned: HttpRequest;
Expand Down

0 comments on commit 54990fa

Please sign in to comment.