Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Handle header lists in URLConnection client (#4897)" (#4960)" #5043

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

millems
Copy link
Contributor

@millems millems commented Mar 25, 2024

This reverts commit e715bb6.

X-ray has fixed a risk of customers double-adding the x-ray interceptor, and SQS will no longer reject requests with "invalid" x-ray trace IDs. It should be safe to re-release this URL connection fix for multi-value headers.

…4960)"

This reverts commit e715bb6.

X-ray has fixed a risk of customers double-adding the x-ray interceptor, and SQS will no longer reject requests with "invalid" x-ray trace IDs. It should be safe to re-release this URL connection fix for multi-value headers.
@millems millems requested a review from a team as a code owner March 25, 2024 21:24
@millems millems enabled auto-merge (squash) March 25, 2024 21:28
Copy link

@millems millems merged commit f91a8dd into master Mar 25, 2024
16 of 17 checks passed
@millems millems deleted the millem/url-connection-revert-revert branch March 25, 2024 22:10
akidambisrinivasan pushed a commit to akidambisrinivasan/aws-sdk-java-v2 that referenced this pull request Jun 28, 2024
…" (aws#4960)" (aws#5043)

This reverts commit e715bb6.

X-ray has fixed a risk of customers double-adding the x-ray interceptor, and SQS will no longer reject requests with "invalid" x-ray trace IDs. It should be safe to re-release this URL connection fix for multi-value headers.
@ngudbhav
Copy link

ngudbhav commented Sep 3, 2024

Was this code change reverted? We are facing this issue again here #4746 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants