Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salande/merge master acctid #4978

Merged

Conversation

cenedhryn
Copy link
Contributor

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

AWS and others added 30 commits January 29, 2024 19:12
…ddress to include direction to add path when providing a JSON file.
…e08f15750

Pull request: release <- staging/22b991eb-2caa-49ef-9691-57de08f15750
* chore: a more polite closed issue message

* chore: relax stale issue timing
Modifying the SDK client configuration at the request level uses extra memory, because it requires copying the existing configuration map.

Before this change, we always modify the client configuration with each request to add the client instance. This change moves this modification to the client-creation, so that the configuration doesn't need to be copied unless plugins also modify the configuration.

This change also removes the conditional logic that only added the client for S3, which simplifies the code generator.
…d new skipDeletionCheck to DeleteProject which also automatically deletes dependent objects
…c828dcbe6

Pull request: release <- staging/6a11e764-329c-484d-8b19-653c828dcbe6
1. Do not call SignerProperty.toString() whenever required properties are read.
2. Check if an SdkHttpRequest is an SdkHttpFullRequest before performing a full conversion to the latter.
1. Removed apply*Hack method. This method wasn't doing anything, because its side effects were immediately overridden.
2. Do not modify the execution context in the modify* methods unless the interceptor requests a modification. The time added by the comparisons are less than the cost of always modifying the interceptor context, because modifying the execution context is relatively rare.
…sed by flexible checksums in S3. (#4858)

Before this change, our chunk encoding logic would copy customer data five times:
1. [From the customer's stream into a byte array.](https://github.com/aws/aws-sdk-java-v2/blob/6040b2be6731e4b5ef64e775a2cfffb07d76766c/core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedInputStream.java#L106-L107)
2. [From the byte array into a slightly smaller byte array.](https://github.com/aws/aws-sdk-java-v2/blob/6040b2be6731e4b5ef64e775a2cfffb07d76766c/core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedInputStream.java#L111)
3. [From the smaller byte array into a byte array output stream.](https://github.com/aws/aws-sdk-java-v2/blob/6040b2be6731e4b5ef64e775a2cfffb07d76766c/core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedInputStream.java#L171)
4. [From the byte array output stream into an array.](https://github.com/aws/aws-sdk-java-v2/blob/6040b2be6731e4b5ef64e775a2cfffb07d76766c/core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedInputStream.java#L149)
5. [From the array into the output array.](https://github.com/aws/aws-sdk-java-v2/blob/6040b2be6731e4b5ef64e775a2cfffb07d76766c/core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/internal/signer/chunkedencoding/ChunkedEncodedInputStream.java#L85)

After this change, the logic will copy the data twice:
1. From the customer's stream into a byte array.
2. From the byte array into the output array.

There's a path to make it only one copy, but it requires the chunk encoded input stream to know the length of the underlying stream so that it can detect when the last chunk will be encountered. This will require additional piping, so we can do it in a follow-up PR.
…draining intervals for Network Load Balancers.
… scan existing resources in your account and select resources to generate a template for a new or existing CloudFormation stack.
…onal Duration parameter to StateManager Associations. This allows customers to specify how long an apply-only-on-cron association execution should run. Once the specified Duration is out all the ongoing cancellable commands or automations are cancelled.
…a131f31e5

Pull request: release <- staging/590b85ab-f197-473d-a0c3-616a131f31e5
The original check checks whether the tag *exists* in the local and then tries
to remove it from the public repo. However, it's possible that the tag is in the
private repo, where it might not exists (refs from both remotes are present
locally).

This commit fixes this by explicitly check if the tag exists in the public repo
and only then will it try to delete it.
AWS and others added 21 commits February 26, 2024 19:11
…for gp3 data volumes for Multi-AZ DB Clusters.
… with new TagResource, UntagResource and ListTagsForResource APIs to manage tags and updates to existing APIs to allow tag on create. This release also adds support for the new DeleteWorkerConfiguration API.
…433c12aee

Pull request: release <- staging/0efbc641-68ea-420b-94c4-c06433c12aee
* Remove the use of the legacy signer

* Remove extra whitespace

* Small commit to kick the build

* Remove the profiles dependency that is not needed anymore
…oad (#4951)

* Enable transfer listener for Java-based TransferManager multipart upload

* Add Java Progress Listener and refactor

* Refactoring

* Fix merge

* Address comments

* Address comments

* Add changelog entry

* Make NoOpPublisherListener static

* Remove static modifier
…p client. (#4962)

* Support Non proxy host settings in the ProxyConfiguration for Crt http client.

* Handled comments
…45e1b6492

Pull request: release <- staging/d5590a20-fdb4-4c31-87db-06445e1b6492
Revert "Support Non proxy host settings in the ProxyConfiguration for  Crt http client. (#4962)"
…RequestBody#writeInputStream` could get stuck if any of the multipart request fails. (#4970)
Re-enable japicmp for S3
@cenedhryn cenedhryn requested a review from a team as a code owner February 28, 2024 19:56
@cenedhryn cenedhryn closed this Feb 28, 2024
@cenedhryn cenedhryn deleted the salande/merge-master-acctid branch February 28, 2024 19:56
@cenedhryn cenedhryn restored the salande/merge-master-acctid branch February 28, 2024 19:56
@cenedhryn cenedhryn reopened this Feb 28, 2024
Copy link

@cenedhryn cenedhryn merged commit 20d8243 into feature/master/accountid-endpoint-routing Feb 29, 2024
16 of 17 checks passed
@cenedhryn cenedhryn deleted the salande/merge-master-acctid branch May 13, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.