Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge enable CRC32 change #4905

Merged

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented Feb 8, 2024

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

davidh44 and others added 2 commits February 8, 2024 15:05
* AWS Glue Update: Introduce Catalog Encryption Role within Glue Data Catalog Settings. Introduce SASL/PLAIN as an authentication method for Glue Kafka connections

* Amazon WorkSpaces Update: Added definitions of various WorkSpace states

* Release 2.23.18. Updated CHANGELOG.md, README.md and all pom.xml.

* update aws-sdk-java pom to add imds and dyanmodb-enhanced (#4890)

* Performance improvement for sigv4 signing. (#4891)

This is a reintroduction of the reverted commit #4867. This includes a fix to the issue that caused the revert: improper handling of empty header values.

* Update to next snapshot version: 2.23.19-SNAPSHOT

* Delete CloudSearchv2IntegrationTest (#4888)

* Fix tag deletion command (#4892)

* including S3 Access Grants Plugin as part of Java SDK Bundle (#4881)

* including S3 Access Grants Plugin as part of Java SDK Bundle

---------

Co-authored-by: Shiva Kumar Mukkapati <[email protected]>

* Archive old changelog entries (< 2.23.0) (#4873)

- .json files files for each version are grouped under minor versions in
   .changes
 - Markdown files for each minor version are created in changelogs/ directory
 - Changelog scripts updated to add a link to older version in the generated
   changelog

* Changing indentation of config files to 4 spaces (#4889)

* Amazon EC2 Container Service Update: This release is a documentation only update to address customer issues.

* AWS WAFV2 Update: You can now delete an API key that you've created for use with your CAPTCHA JavaScript integration API.

* Amazon OpenSearch Service Update: This release adds clear visibility to the customers on the changes that they make on the domain.

* AWS AppSync Update: Support for environment variables in AppSync GraphQL APIs

* Amazon CloudWatch Logs Update: This release adds a new field, logGroupArn, to the response of the logs:DescribeLogGroups action.

* Amazon Elasticsearch Service Update: This release adds clear visibility to the customers on the changes that they make on the domain.

* Release 2.23.19. Updated CHANGELOG.md, README.md and all pom.xml.

* Update to next snapshot version: 2.23.20-SNAPSHOT

* Bump CRT version and expose setting memory limits for S3 calls (#4885)

* Bump aws-crt version to 0.29.9

* Exposes a setting to set the memory limit when making asynchronous calls with the CRT-based S3 client

* Activating SRA for this service (#4896)

* Fix request cancellation logic in the AWS CRT Sync HTTP client (#4887)

* Fix request cancellation logic in the AWS CRT Sync HTTP client

* Address feedback

* Fix bug to allow MpuS3Client to PUT COPY with SSE-C and Checksum

* Enable CRC32 for Multipart PUT COPY

* Address comments

* add changelog and update checksum check

* Address comments

* update javadocs

* Add unit tests

---------

Co-authored-by: AWS <>
Co-authored-by: aws-sdk-java-automation <[email protected]>
Co-authored-by: Zoe Wang <[email protected]>
Co-authored-by: Matthew Miller <[email protected]>
Co-authored-by: John Viegas <[email protected]>
Co-authored-by: Dongie Agnir <[email protected]>
Co-authored-by: shiva kumar <[email protected]>
Co-authored-by: Shiva Kumar Mukkapati <[email protected]>
Co-authored-by: Anna-Karin Salander <[email protected]>
@davidh44 davidh44 requested a review from a team as a code owner February 8, 2024 23:14
@davidh44 davidh44 merged commit 1849320 into hdavidh/pause-resume-upload-java Feb 8, 2024
@davidh44 davidh44 deleted the hdavidh/merge-enable-crc32 branch February 8, 2024 23:14
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
56.8% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

davidh44 added a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant