Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auto reads on idling connections #4655

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Oct 31, 2023

Motivation and Context

This change enables auto reads on idling connections, and disables them on in-use connections (no auto read for in-use connections is existing behavior). Auto reads while the channel is idling allows the channel to read and immediately handle events that are triggered by the remote end such as TLS close notifies. In particular this fixes issues where a channel is leased only for the SDK to find that the remote end has initiated a shutdown of the TLS connection.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir marked this pull request as ready for review November 7, 2023 00:05
@dagnir dagnir requested a review from a team as a code owner November 7, 2023 00:05
@dagnir dagnir force-pushed the dongie/idle-auto-reads branch from 8a8d1ae to f65d17b Compare November 8, 2023 22:10
This change enables auto reads on idling connections, and disables them on
in-use connections (no auto read for in-use connections is existing behavior).
Auto reads while the channel is idling allows the channel to read and
immediately handle events that are triggered by the remote end such as TLS close
notifies. In particular this fixes issues where a channel is leased only for the
SDK to find that the remote end has initiated a shutdown of the TLS connection.
@dagnir dagnir force-pushed the dongie/idle-auto-reads branch from f65d17b to aea1efc Compare November 8, 2023 22:18
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants