UpdateExpression API #2900
Merged
UpdateExpression API #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
reviewed
Dec 8, 2021
...odb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/UpdateAction.java
Outdated
Show resolved
Hide resolved
...enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/UpdateExpression.java
Outdated
Show resolved
Hide resolved
...enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/UpdateExpression.java
Outdated
Show resolved
Hide resolved
...enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/UpdateExpression.java
Outdated
Show resolved
Hide resolved
millems
reviewed
Dec 8, 2021
...enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/UpdateExpression.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Dec 9, 2021
...-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/AddUpdateAction.java
Outdated
Show resolved
Hide resolved
...-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/AddUpdateAction.java
Outdated
Show resolved
Hide resolved
...-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/AddUpdateAction.java
Show resolved
Hide resolved
...-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/AddUpdateAction.java
Outdated
Show resolved
Hide resolved
...enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/UpdateExpression.java
Outdated
Show resolved
Hide resolved
...enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/UpdateExpression.java
Show resolved
Hide resolved
millems
reviewed
Dec 9, 2021
...-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/AddUpdateAction.java
Show resolved
Hide resolved
| private AddUpdateAction(Builder builder) { | ||
| this.path = Validate.paramNotNull(builder.path, "path"); | ||
| this.value = Validate.paramNotNull(builder.value, "value"); | ||
| this.expressionValues = unmodifiableMap(Validate.paramNotNull(builder.expressionValues, "expressionValues")); |
There was a problem hiding this comment.
Is it true that this must always be non-null?
There was a problem hiding this comment.
AFAIK; not sure if you're just referring to expressionValues or all of them. For expressionValues I believe so, but we should test this premise before release. I figured it's better to be restrictive at first.
zoewangg
reviewed
Dec 9, 2021
| this.path = Validate.paramNotNull(builder.path, "path"); | ||
| this.value = Validate.paramNotNull(builder.value, "value"); | ||
| this.expressionValues = unmodifiableMap(Validate.paramNotNull(builder.expressionValues, "expressionValues")); | ||
| this.expressionNames = unmodifiableMap(builder.expressionNames != null ? builder.expressionNames : new HashMap<>()); |
There was a problem hiding this comment.
Don't we need to wrap it with a new HashMap?
...enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/UpdateExpression.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public List<RemoveUpdateAction> removeActions() { | ||
| return Collections.unmodifiableList(removeActions); |
There was a problem hiding this comment.
I think we should create a new List and wrap it with unmodifiableList in the ctor. Can we do a find and replace to fix all occurrences of list and map?
...enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/update/UpdateExpression.java
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
zoewangg
approved these changes
Dec 10, 2021
aws-sdk-java-automation
added a commit
that referenced
this pull request
Feb 14, 2024
…22e43c3d4 Pull request: release <- staging/82f02350-8349-48bb-a3e4-b3f22e43c3d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In order to support DynamoDB UpdateExpressions we need a representation of these concepts in the public API.
https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Expressions.UpdateExpressions.html
Description
Adding a set of classes to represent UpdateExpression actions, and an UpdateExpression class to contain them. See separate design document for motivation and architecture.
Testing
Unit tested.