Log channel ID when logging error #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
channel-id-logging
branch
from
7b3f953 to
5c2528c
Compare
Bennett-Lynch
approved these changes
Dec 7, 2021
...lient/src/main/java/software/amazon/awssdk/http/nio/netty/internal/NettyRequestExecutor.java
Outdated
Show resolved
Hide resolved
...ent/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/ChannelLogHelper.java
Outdated
Show resolved
Hide resolved
...ent/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/ChannelLogHelper.java
Outdated
Show resolved
Hide resolved
...ent/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/ChannelLogHelper.java
Outdated
Show resolved
Hide resolved
dagnir
force-pushed
the
channel-id-logging
branch
from
1f6f2da to
300cc57
Compare
...lient/src/main/java/software/amazon/awssdk/http/nio/netty/internal/NettyRequestExecutor.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyClientLogger.java
Show resolved
Hide resolved
...nt/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyClientLogger.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyClientLogger.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We seem to have quite a few other Netty-based classes that could benefit from this logger. E.g., here is one I chose at random. How can we go about making sure this logger is more consistently used?
Now that we have switched to full-fledged facade, it would be easier to do that by enforcing the use of this logger only within the Netty module. |
Bennett-Lynch
approved these changes
Dec 8, 2021
...nt/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyClientLogger.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyClientLogger.java
Outdated
Show resolved
Hide resolved
zoewangg
approved these changes
Dec 8, 2021
dagnir
force-pushed
the
channel-id-logging
branch
from
b1feca0 to
a34d7e3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Bennett-Lynch
approved these changes
Dec 8, 2021
aws-sdk-java-automation
added a commit
that referenced
this pull request
Feb 7, 2024
…2798c8cb1 Pull request: release <- staging/1c0c8ade-7bcb-4158-8160-4962798c8cb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Better logging.
Description
Testing
Added unit tests, ran integration tests.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense