Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lambda service integration test to wait for function to be Active after createFunction #2886

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Conversation

joviegas
Copy link
Contributor

@joviegas joviegas commented Dec 3, 2021

Motivation and Context

Description

  • Added a waiter to wait until function is active.

Testing

  • tested in Integ account.

Screenshots (if appropriate)

Types of changes

  • [ x]Integration Test update

Checklist

  • I have read the CONTRIBUTING document

License

  • [x ] I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner December 3, 2021 18:04
@joviegas joviegas changed the title Update lambda service intergration test to wait for function to be Active after createFunction Update lambda service integration test to wait for function to be Active after createFunction Dec 3, 2021
@@ -81,11 +81,14 @@ public void uploadFunction() throws IOException {
.timeout(10)
.role(lambdaServiceRoleArn)).join();

lambda.waiter()
.waitUntilFunctionActive(r -> r.functionName(FUNCTION_NAME))
.whenComplete((r, t) -> {}).join();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It seems .whenComplete((r, t) -> {}) is not needed

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@joviegas joviegas merged commit 931ea4d into aws:master Dec 7, 2021
aws-sdk-java-automation pushed a commit that referenced this pull request Feb 1, 2024
Add option to disable EC2 metadata (IMDS) calls without token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants