Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guava 28.2 #1562

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Guava 28.2 #1562

merged 1 commit into from
Dec 31, 2019

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Dec 27, 2019

Description

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

dagnir
dagnir reviewed Dec 30, 2019
View reviewed changes
.changes/next-release/bugfix-build-4fc7ad5.json Outdated
@@ -0,0 +1,5 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK Guava is only used in tests; we should remove this since it doesn't affect users of the SDK

dagnir
dagnir approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@dagnir dagnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dagnir dagnir merged commit 1dae0af into aws:master Dec 31, 2019
@sullis sullis deleted the guava-28.2 branch December 31, 2019 21:10
aws-sdk-java-automation added a commit that referenced this pull request Jul 23, 2021
@aws-sdk-java-automation
Merge pull request #1562 from aws/staging/cfe2ee53-79e8-449d-aa63-0a7…
062a48c 
…34b12c253

Pull request: release <- staging/cfe2ee53-79e8-449d-aa63-0a734b12c253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagnir dagnir dagnir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sullis @dagnir